Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Remove broken and unused reactive roles #1746

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jan 9, 2025

The reactive roles were an early prototype we were doing at curvenote. These shouldn't be included in the myst-cli as they don't work and have no renderer.

This removes them from the docs and default directive/roles.

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: d514e37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
myst-cli Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 91 to 94
"myst-to-typst": "^0.0.28",
"myst-transforms": "^1.3.28",
"myst-toc": "^0.1.2",
"myst-transforms": "^1.3.28",
"nanoid": "^4.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change here, just ordering.

Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleaning up legacy, unused stuff!

@fwkoch fwkoch merged commit 479db78 into main Jan 9, 2025
7 checks passed
@fwkoch fwkoch deleted the trash/reactive-roles branch January 9, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants