Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Remove broken and unused reactive roles #1746

Merged
merged 1 commit into from
Jan 9, 2025
Merged

🚮 Remove broken and unused reactive roles #1746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/weak-bats-fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"myst-cli": patch
---

Remove broken and unused reactive roles.
4 changes: 1 addition & 3 deletions docs/directives.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { cardDirective } from 'myst-ext-card';
import { gridDirectives } from 'myst-ext-grid';
import { proofDirective } from 'myst-ext-proof';
import { exerciseDirectives } from 'myst-ext-exercise';
import { reactiveDirective, reactiveRole } from 'myst-ext-reactive';
import { tabDirectives } from 'myst-ext-tabs';
import { fileError } from 'myst-common';

Expand All @@ -15,11 +14,10 @@ const allDirectives = [
...gridDirectives,
...exerciseDirectives,
...tabDirectives,
reactiveDirective,
cardDirective,
proofDirective,
];
const allRoles = [...defaultRoles, reactiveRole];
const allRoles = [...defaultRoles];

/**
* @param {import('myst-common').OptionDefinition} option
Expand Down
2 changes: 1 addition & 1 deletion packages/myst-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@
"myst-to-md": "^1.0.14",
"myst-to-tex": "^1.0.40",
"myst-to-typst": "^0.0.28",
"myst-transforms": "^1.3.28",
"myst-toc": "^0.1.2",
"myst-transforms": "^1.3.28",
"nanoid": "^4.0.0",
Comment on lines 91 to 94
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change here, just ordering.

"nbtx": "^0.2.3",
"node-fetch": "^3.3.1",
Expand Down
4 changes: 1 addition & 3 deletions packages/myst-cli/src/process/myst.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { cardDirective } from 'myst-ext-card';
import { gridDirectives } from 'myst-ext-grid';
import { proofDirective } from 'myst-ext-proof';
import { exerciseDirectives } from 'myst-ext-exercise';
import { reactiveDirective, reactiveRole } from 'myst-ext-reactive';
import { tabDirectives } from 'myst-ext-tabs';
import { VFile } from 'vfile';
import type { ISession } from '../session/types.js';
Expand Down Expand Up @@ -40,7 +39,6 @@ export function parseMyst(
directives: [
cardDirective,
...gridDirectives,
reactiveDirective,
proofDirective,
...exerciseDirectives,
...tabDirectives,
Expand All @@ -49,7 +47,7 @@ export function parseMyst(
extensions: {
frontmatter: !opts?.ignoreFrontmatter,
},
roles: [reactiveRole, ...(session.plugins?.roles ?? [])],
roles: [...(session.plugins?.roles ?? [])],
vfile,
});
logMessagesFromVFile(session, vfile);
Expand Down
Loading