🚮 Remove broken and unused reactive roles (#1746)

jupyter-book · Jan 9, 2025 · 479db78 · 479db78
1 parent 6f77bda
commit 479db78
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/.changeset/weak-bats-fetch.md b/.changeset/weak-bats-fetch.md
@@ -0,0 +1,5 @@
+---
+"myst-cli": patch
+---
+
+Remove broken and unused reactive roles.
diff --git a/docs/directives.mjs b/docs/directives.mjs
@@ -6,7 +6,6 @@ import { cardDirective } from 'myst-ext-card';
 import { gridDirectives } from 'myst-ext-grid';
 import { proofDirective } from 'myst-ext-proof';
 import { exerciseDirectives } from 'myst-ext-exercise';
-import { reactiveDirective, reactiveRole } from 'myst-ext-reactive';
 import { tabDirectives } from 'myst-ext-tabs';
 import { fileError } from 'myst-common';
 
@@ -15,11 +14,10 @@ const allDirectives = [
   ...gridDirectives,
   ...exerciseDirectives,
   ...tabDirectives,
-  reactiveDirective,
   cardDirective,
   proofDirective,
 ];
-const allRoles = [...defaultRoles, reactiveRole];
+const allRoles = [...defaultRoles];
 
 /**
  * @param {import('myst-common').OptionDefinition} option

diff --git a/packages/myst-cli/package.json b/packages/myst-cli/package.json
@@ -89,8 +89,8 @@
     "myst-to-md": "^1.0.14",
     "myst-to-tex": "^1.0.40",
     "myst-to-typst": "^0.0.28",
-    "myst-transforms": "^1.3.28",
     "myst-toc": "^0.1.2",
+    "myst-transforms": "^1.3.28",
     "nanoid": "^4.0.0",
     "nbtx": "^0.2.3",
     "node-fetch": "^3.3.1",

diff --git a/packages/myst-cli/src/process/myst.ts b/packages/myst-cli/src/process/myst.ts
@@ -3,7 +3,6 @@ import { cardDirective } from 'myst-ext-card';
 import { gridDirectives } from 'myst-ext-grid';
 import { proofDirective } from 'myst-ext-proof';
 import { exerciseDirectives } from 'myst-ext-exercise';
-import { reactiveDirective, reactiveRole } from 'myst-ext-reactive';
 import { tabDirectives } from 'myst-ext-tabs';
 import { VFile } from 'vfile';
 import type { ISession } from '../session/types.js';
@@ -40,7 +39,6 @@ export function parseMyst(
     directives: [
       cardDirective,
       ...gridDirectives,
-      reactiveDirective,
       proofDirective,
       ...exerciseDirectives,
       ...tabDirectives,
@@ -49,7 +47,7 @@ export function parseMyst(
     extensions: {
       frontmatter: !opts?.ignoreFrontmatter,
     },
-    roles: [reactiveRole, ...(session.plugins?.roles ?? [])],
+    roles: [...(session.plugins?.roles ?? [])],
     vfile,
   });
   logMessagesFromVFile(session, vfile);