Store the WebDriver error "data" property #48866
Conversation
There was a problem hiding this comment.
I'm totally up for this but please note that there is as well w3c/webdriver#1615 for discussion. We should get to a consensus first if we want that property or not.
I don't think anyone is suggesting removing it — that issue seems to be about whether "execute script" (and presumably "execute async script") set the data property? It already exists in general for errors. |
tools/webdriver/webdriver/error.py
Outdated
| @@ -213,6 +221,8 @@ def from_response(response): | |||
| code = value["error"] | |||
| message = value["message"] | |||
| stack = value["stacktrace"] or None | |||
| # data is optional, and could even be an empty dict | |||
| data = value.get("data") or None | |||
|
|
|||
| cls = get(code) | |||
| return cls(response.status, code, message, stacktrace=stack) | |||
There was a problem hiding this comment.
Without that we won't set the data property:
| return cls(response.status, code, message, stacktrace=stack) | |
| return cls(response.status, code, message, stacktrace=stack, data=data) |
|
@gsnedders do you have an update for this PR? |
|
ping @gsnedders |
gsnedders
force-pushed
the
store-webdrivererror-data
branch
from
8fdc126 to
64a34c8
Compare
I've updated this now! |
It's unclear to me why this wasn't here before; it's been in the spec longer than we've stored anything on
WebDriverException(specifically w3c/webdriver@33b1404 predates 726d661).