You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently canonicalize an empty message string to None, an empty stacktrace string to None, and an empty data object to None.
As @whimboo reasonably pointed out in the above review thread,
I think we shouldn’t modify the returned value if it’s an empty list (or any similar value that evaluates to None). Doing so would alter the data we actually want to test and could lead to discrepancies with the spec—or could let issues slip by unnoticed, such as when a client returns an incorrect type.
We should maybe revisit this.
The stacktrace case goes back to when the code was originally written in 48edfb1 (no justification given for this behaviour), the message case goes back to 3b83423 when I changed it to make the if message is None check actually work, and the data case goes back to when #48866 lands, matching the other two.
The text was updated successfully, but these errors were encountered:
See https://github.com/web-platform-tests/wpt/pull/48866/files#r1821477471
We currently canonicalize an empty
message
string toNone
, an emptystacktrace
string toNone
, and an emptydata
object toNone
.As @whimboo reasonably pointed out in the above review thread,
We should maybe revisit this.
The
stacktrace
case goes back to when the code was originally written in 48edfb1 (no justification given for this behaviour), themessage
case goes back to 3b83423 when I changed it to make theif message is None
check actually work, and thedata
case goes back to when #48866 lands, matching the other two.The text was updated successfully, but these errors were encountered: