github: replace call for sleep with wait-for-it.sh #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 75.11% 75.12%
=======================================
Files 132 132
Lines 34397 34400 +3
=======================================
+ Hits 25837 25842 +5
+ Misses 8560 8558 -2 ☔ View full report in Codecov by Sentry. |
Previously integration tests invoked `sleep 10` to "give time to settle" the environment. In a fast container, waiting for so long is not needed and in a slow one it might not be enough. This commit changes this line to use `./util/wait-for-it.sh` instead [1] to check robustly that the port is being listened to. Fixes #49. [1] https://github.com/vishnubob/wait-for-it Signed-off-by: Mikhail Koviazin <[email protected]>
If the cluster has just been started, `CLUSTER SLOTS` returns an empty array. `NodesManager.initialize` did not take this into account and took the first element unconditionally causing `IndexError`. This commit makes it raise `ValkeyClusterException` with a clear error message instead. Signed-off-by: Mikhail Koviazin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously integration tests invoked
sleep 10to "give time to settle" the environment. In a fast container, waiting for so long is not needed and in a slow one it might not be enough.This commit changes this line to use
./util/wait-for-it.shinstead [1] to check robustly that the port is being listened to.Fixes #49.
[1] https://github.com/vishnubob/wait-for-it
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.