Skip to content

Commit

Permalink
Merge pull request #81 from mkmkme/mkmkme/issue-49
Browse files Browse the repository at this point in the history
github: replace call for sleep with wait-for-it.sh
  • Loading branch information
aiven-sal authored Sep 4, 2024
2 parents b10b338 + 798569b commit b424517
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ jobs:
pip install "libvalkey>=4.0.0"
fi
invoke devenv
sleep 10 # time to settle
if [[ "${{matrix.test-type}}" == "standalone" ]]; then
./util/wait-for-it.sh localhost:6379
else
./util/wait-for-it.sh localhost:16379
fi
invoke ${{matrix.test-type}}-tests --protocol=${{ matrix.protocol-version }}
if [[ "${{matrix.python-version}}" != pypy-* ]]; then
invoke ${{matrix.test-type}}-tests --uvloop --protocol=${{ matrix.protocol-version }}
Expand Down
5 changes: 4 additions & 1 deletion valkey/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -1648,7 +1648,10 @@ def initialize(self):
self.nodes_cache = tmp_nodes_cache
self.slots_cache = tmp_slots
# Set the default node
self.default_node = self.get_nodes_by_server_type(PRIMARY)[0]
try:
self.default_node = self.get_nodes_by_server_type(PRIMARY)[0]
except IndexError:
raise ValkeyClusterException("No primary nodes found in the cluster")
if self._dynamic_startup_nodes:
# Populate the startup nodes with all discovered nodes
self.startup_nodes = tmp_nodes_cache
Expand Down

0 comments on commit b424517

Please sign in to comment.