Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add "team project" filtering to /cohortdefinition-stats endpoint #81

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Feat: add "team project" filtering to /cohortdefinition-stats endpoint #81

merged 3 commits into from
Dec 13, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Nov 29, 2023 •
edited
Loading

Jira Ticket: VADC-618

Breaking Changes

  • add "team project" filtering to /cohortdefinition-stats endpoint. This means that the /cohortdefinition-stats/by-source-id/:sourceid/ got an extra mandatory parameter and looks like this now: /cohortdefinition-stats/by-source-id/:sourceid/by-team-project/:teamproject

Deployment changes

  • a new SQL VIEW should be added to the Atlas/WebAPI database that contains the sec_ tables (see view added to tests/setup_local_db/ddl_atlas.sql and comment here)

@pieterlukasse pieterlukasse force-pushed the feat/integrate_team_project_checks branch from 16c2760 to ff23235 Compare December 1, 2023 20:56
@pieterlukasse pieterlukasse changed the title Feat: add sec_ tables + view and test data Feat: add "team project" filtering to /cohortdefinition-stats endpoint Dec 4, 2023
@pieterlukasse pieterlukasse marked this pull request as ready for review December 4, 2023 19:21
@pieterlukasse pieterlukasse force-pushed the feat/integrate_team_project_checks branch from ff23235 to dbe506d Compare December 4, 2023 19:32
@pieterlukasse pieterlukasse changed the base branch from master to feat/team_project_feature December 4, 2023 19:37
@pieterlukasse pieterlukasse force-pushed the feat/integrate_team_project_checks branch from dbe506d to d009aa7 Compare December 4, 2023 19:41
tianj7
tianj7 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments

models/cohortdefinition.go Outdated Show resolved Hide resolved
tests/controllers_tests/controllers_test.go Show resolved Hide resolved
@pieterlukasse pieterlukasse merged commit 6751594 into feat/team_project_feature Dec 13, 2023
11 checks passed
@pieterlukasse pieterlukasse deleted the feat/integrate_team_project_checks branch December 13, 2023 13:58
@pieterlukasse pieterlukasse mentioned this pull request Jan 8, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianj7 tianj7 tianj7 approved these changes

@m0nhawk m0nhawk Awaiting requested review from m0nhawk

Assignees
No one assigned
Labels
test-portal-homepageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @tianj7