Feat: team project feature #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and add both real and mock implementations. This makes this part easier to test.
...and add respective tests
Feat: add "team project" filtering to /cohortdefinition-stats endpoint
…_validation_for_team_project
...which is cohort_definition_id...there is no such thing as "cohort id"
…n_for_team_project Feat: integrate extra 'team project' validation for concept endpoints
Important: these can only be added back with proper changes to ensure the correct "team project" filtering takes place
...to support team projects that start with "/"
...over the other variation of this method (TeamProjectValidationForCohortIdsList)
…n_for_team_project_for_cohort_data_endpoints Feat: integrate Arborist validation for team project for cohort data endpoints AND remove unused endpoints
vzpgb
approved these changes
Jan 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts (part of) commit c38cfad.
pieterlukasse
force-pushed
the
feat/team_project_feature
branch
from
a869df7 to
1836c2b
Compare
pieterlukasse
force-pushed
the
feat/team_project_feature
branch
from
80108b6 to
9ac8935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Tickets: VADC-618, VADC-839
Note: this PR is a combination of PRs #81, #82, #83 (reflected in the descriptions below). The one additional thing this PR does is:
New Features
Bug Fixes
/cohortdefinition-stats/by-source-id/:sourceid/by-team-projectto support a URL query parameter where the "team project" can also start with/Breaking Changes
/cohortdefinition-stats/by-source-id/:sourceid/got an extra mandatory parameter and looks like this now:/cohortdefinition-stats/by-source-id/:sourceid/by-team-project/:teamprojectDeployment changes
sec_tables (see view added totests/setup_local_db/ddl_atlas.sqland comment here)