Mark Kendall #5
Open
Mark Kendall #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love that you focused on TDD for this challenge!! This one can be 'fun' to get the test stetup into a situation that will ensure no false positives 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generally felt comfortable during the entirety of the challenge. I was able to pace myself on each iteration to have a sense whether I was on track to completion within our allotted time. I focused on TDD, doing my best to (usually) first write tests and then the corresponding class methods / related code in a way that would make the tests pass. With remaining time, I refactored code, cleaned up messier segments, and strengthened the tests to minimize potential issues like false positives. I'm pleased with the outcome; it would probably be wise for me to commit slightly more often (though I started increasing the rate as I reached more involved / 'tricky' methods).