Jaren Garman #4
Open
Jaren Garman #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/candidate
Feature/race
Feature/election
Feature/run and results
JarenGarman
commented
Jan 7, 2025
lib/election.rb
Outdated
| end | ||
|
|
||
| def vote_counts | ||
| counts = {} |
There was a problem hiding this comment.
is there an enumerable or different way of creating a hash that would allow me to create and return the hash all on one line? it feels kinda clunky to have to create an empty hash and then return it at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This IC went pretty well for me! I tried my hand at using mocks and stubs, I would like some specific feedback on if I used them correctly or if there are any potential issues with my implementation. I also made use of SimpleCov and got 100% on both line and branch coverage