Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review changes #417

Merged
merged 1 commit into from
Nov 7, 2023
Merged

code review changes #417

merged 1 commit into from
Nov 7, 2023

Conversation

pastuxso
Copy link
Collaborator

@pastuxso pastuxso commented Nov 6, 2023 •
edited
Loading

No description provided.

@pastuxso pastuxso marked this pull request as ready for review November 6, 2023 23:19
@pastuxso pastuxso requested a review from sourishkrout November 6, 2023 23:20
sourishkrout
sourishkrout approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pastuxso pastuxso marked this pull request as draft November 7, 2023 15:58
@pastuxso pastuxso marked this pull request as ready for review November 7, 2023 16:32
@pastuxso pastuxso merged commit 8ac1456 into v2 Nov 7, 2023
4 checks passed
@pastuxso pastuxso deleted the pastuxso/review branch November 7, 2023 16:44
pastuxso added a commit that referenced this pull request Nov 7, 2023
@pastuxso
code review changes (#417)
0d1ea99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pastuxso @sourishkrout