code review changes (#417)

Makefile

@@ -10,6 +10,10 @@ LDFLAGS := -s -w \
 	-X 'github.com/stateful/runme/internal/version.BuildVersion=$(subst v,,$(VERSION))' \
 	-X 'github.com/stateful/runme/internal/version.Commit=$(GIT_SHA)'
 
+ifeq ($(RUNME_EXT_BASE),)
+RUNME_EXT_BASE := "../vscode-runme"
+endif
+
 .PHONY: build
 build:
 	go build -o runme -ldflags="$(LDFLAGS)" main.go

internal/version/version_test.go

@@ -6,8 +6,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestGetMinorVersion(t *testing.T) {
-	// Test cases
+func TestBaseVersion(t *testing.T) {
 	tests := []struct {
 		name          string
 		buildVersion  string
@@ -33,14 +32,17 @@ func TestGetMinorVersion(t *testing.T) {
 			buildVersion:  "0.0.0",
 			expectedMinor: "0.0",
 		},
+		{
+			name:          "invalid semver",
+			buildVersion:  "1.2.beta",
+			expectedMinor: "unknown",
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			BuildVersion = tt.buildVersion
-
 			baseVersion := BaseVersion()
-
 			assert.Equal(t, tt.expectedMinor, baseVersion)
 		})
 	}

main_test.go

@@ -71,13 +71,13 @@ func TestSkipPromptsWithinAPty(t *testing.T) {
 
 	expected := "The content of ENV is <insert-env-here>"
 	current := buf.String()
-	current = RemoveAnsiCodes(current)
+	current = removeAnsiCodes(current)
 	current = strings.TrimSpace(current)
 
 	assert.Equal(t, expected, current, "Output does not match")
 }
 
-func RemoveAnsiCodes(str string) string {
+func removeAnsiCodes(str string) string {
 	re := regexp.MustCompile(`\x1b\[.*?[a-zA-Z]|\x1b\].*?\x1b\\`)
 	return re.ReplaceAllString(str, "")
 }