Fix seppJsonMerger.jar #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle different positions for placement fields
…pare against stored truth
|
Hi @smirarab I am adding this PR to address an issue with segfaulting of your bundled pplacer. Relaxing the merger java script will allow to cope with current and new (pplacer 1.1.17 alpha) *.jplace file formats. Can you please review, merge and create a new release to ease updating bioconda packages? This PR does not change any results but also does not fix the pplacer issue directly. To do so, you might want to replace the bundled pplacer binaries with https://github.com/matsen/pplacer/releases/tag/v1.1.alpha17 but this will require some assessment of the changes in the results! |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is (partially) addressing #121.
I made the parsing function of seppJsonMerger.jar more general to cope with different field order in *.jplace files. The order changes from the bundled pplacer (v1.1.alpha13-0-g1ec7786) to the later version (v1.1.alpha17)