gh-121604: fix ResourceLoader deprecation warning message #128859
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
graingert
changed the title
graingert
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
11 tasks
graingert
changed the title
Doc/library/importlib.rst
Outdated
Comment on lines
308
to
310
| Loaders that wish to support resource reading should implement a | ||
| :meth:`get_resource_reader` method as specified by | ||
| :class:`importlib.resources.abc.ResourceReader`. | ||
| :class:`importlib.resources.abc.TraversableResources`. |
There was a problem hiding this comment.
No, it is documented in the importlib.resources.abc.ResourceReader description.
There was a problem hiding this comment.
But ResourceReader is scheduled for removal in 3.14
There was a problem hiding this comment.
When ResourceReader has been removed, the documentation of its methods and of get_resource_reader() should be moved to the TraversableResources description. For now, get_resource_reader() is described with ResourceReader, and the code that implements get_resource_reader() returning ResourceReader still works (but emits a warning).
There was a problem hiding this comment.
Not anymore, see the later comments in #97850
(Responding to Thomas' comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarning#121604