Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning #128007

Merged
merged 15 commits into from
Jan 15, 2025
Merged

gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning #128007

merged 15 commits into from
Jan 15, 2025
+96 −5

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Dec 16, 2024 •
edited by bedevere-app bot
Loading

Largely based on work done by @rashansmith, this adds deprecation warnings for the following importlib classes, methods and attributes (using the docs as the source of truth):

The deprecation messages are based on the docs. Warnings for DEBUG_BYTECODE_SUFFIXES and OPTIMIZED_BYTECODE_SUFFIXES are implemented using a module __getattr__.

Feedback welcome!

@bedevere-app bedevere-app bot mentioned this pull request Dec 16, 2024
Open
11 tasks
@tomasr8
Copy link
Member Author

tomasr8 commented Dec 16, 2024

cc @StanFromIreland

StanFromIreland
StanFromIreland reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things I noticed. I did not have time to go through the rest but it looks good in general.

Lib/importlib/_bootstrap_external.py Outdated Show resolved Hide resolved
Lib/importlib/abc.py Outdated Show resolved Hide resolved
This was referenced Dec 18, 2024
Closed
Open
brettcannon
brettcannon requested changes Jan 6, 2025
View reviewed changes
Lib/importlib/_bootstrap_external.py Outdated Show resolved Hide resolved
Lib/importlib/machinery.py Outdated Show resolved Hide resolved
Lib/importlib/machinery.py Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon
Copy link
Member

Sorry about the review delay!

@tomasr8
Copy link
Member Author

tomasr8 commented Jan 7, 2025

Sorry about the review delay!

No worries, and thanks for the review! I think I addressed your comments if you feel like having another look :)

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jan 7, 2025

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brettcannon January 7, 2025 23:37
@brettcannon brettcannon merged commit bd3baa8 into python:main Jan 15, 2025
38 checks passed
@brettcannon
Copy link
Member

Thanks, @tomasr8 for bearing with me and my delayed reviews! 😅

@tomasr8 tomasr8 deleted the importlib-deprecations branch January 15, 2025 06:59
@tomasr8
Copy link
Member Author

tomasr8 commented Jan 15, 2025

No worries :) Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@graingert graingert graingert left review comments

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomasr8 @brettcannon @graingert @StanFromIreland