Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename ecoscore fields to environmental_score (internal) and new external name and logos #11142

Merged
merged 28 commits into from
Dec 18, 2024
Merged

feat: rename ecoscore fields to environmental_score (internal) and new external name and logos #11142

merged 28 commits into from
Dec 18, 2024

Conversation

stephanegigandet
Copy link
Contributor

Continuation of #11117

We will soon rename the Eco-Score to a new name.

To ease the transition to a new name and be more future proof, we will rename all Eco-Score internal fields to a generic "environmental score" field.

Important notes:

  • the internal attribute id "ecoscore" is not renamed, as it is stored in clients.
  • for the time being, we keep the internal facet id "ecosore" and we copy environmental_score_tags to ecoscore_tags so that MongoDB and off-query can continue to work
  • in order for attributes and knowledge panels to work before Eco-Score has been recomputed (and new environmental_scores fields have been created), the attributes and knowledge panels will use ecoscore_data if environmental_data is not present.

Plan discussed in https://docs.google.com/document/d/1LL8-aiSF482xaJ1o0AKmhXB5QWfVE0_jzvYakq3VXys/edit?tab=t.0#heading=h.pirt3xscsuwq

@stephanegigandet stephanegigandet requested a review from a team as a code owner December 18, 2024 12:22
@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) export 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org Data import 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 🧽 Data quality https://wiki.openfoodfacts.org/Quality API WRITE WRITE API to allow sending product info and image API READ All READ APIs include Product, Search… product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements labels Dec 18, 2024
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Dec 18, 2024
@alexgarel alexgarel changed the base branch from main to environmental-score December 18, 2024 16:02
alexgarel
alexgarel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

html/images/misc/nutriscore/new-nutriscore-header-en.jpg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have this in this PR ?

@stephanegigandet stephanegigandet changed the base branch from environmental-score to main December 18, 2024 16:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@stephanegigandet stephanegigandet merged commit 8a1fec4 into main Dec 18, 2024
15 checks passed
@stephanegigandet stephanegigandet deleted the green branch December 18, 2024 18:19
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 18, 2024
Merged
stephanegigandet pushed a commit that referenced this pull request Dec 18, 2024
@openfoodfacts-bot
chore(main): release 2.52.0 (#11120)
4bbb700 
🤖 I have created a release *beep* *boop*
---


##
[2.52.0](v2.51.0...v2.52.0)
(2024-12-18)


### Features

* change redis stream name to product_updates
([#11141](#11141))
([beb2b64](beb2b64))
* launch new Nutri-Score for France
([#11123](#11123))
([e1a7800](e1a7800))
* rename ecoscore fields to environmental_score (internal) and new
external name and logos
([#11142](#11142))
([8a1fec4](8a1fec4))


### Bug Fixes

* nutripatrol URL
([#11115](#11115))
([8c1d123](8c1d123))
* nutriscore messages
([#11140](#11140))
([7c0ff96](7c0ff96))
* promo images for new nutri-score
([#11144](#11144))
([8a37c8b](8a37c8b))
* redirect /nutriscore-v2 to /new-nutriscore
([#11135](#11135))
([3907e7c](3907e7c))
* switch main nutriscore version to 2023
([#11134](#11134))
([6a0400f](6a0400f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@stephanegigandet stephanegigandet mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
🪶 Apache We use Apache as a server to run Open Food Facts API READ All READ APIs include Product, Search… API v3 API WRITE WRITE API to allow sending product info and image API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Attributes https://wiki.openfoodfacts.org/Product_Attributes config Data import 🧽 Data quality https://wiki.openfoodfacts.org/Quality Display export exports 🌳 Forest Footprint This is a score designed by a French NGO to assess the deforestation impact (in sq meters) 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 💥 Merge Conflicts 💥 Merge Conflicts Minion multilingual products 🚦 Nutri-Score 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Products Tags Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations 🧪 unit tests update all products
Projects
Ingredient analysis
Status: Done
🌐 Review & Merge translations across Open Food Facts
Status: Done
🏭 Producers Platform
Status: Done
🐾 Open Pet Food Facts
Status: Done
📖 Knowledge panels
Status: Done
📦 Packaging improvements
Status: Done
📸 Open Products Facts
Status: Done
🚦Nutri-Score
Status: Done
🛠️ - Server - API
Status: Done
🧴 Open Beauty Facts
Status: Done
🧽 Ensuring Data Quality
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel