refactor: rename ecoscore/eco-score fields to "environmental score" - ready for review #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API
github-actions
bot
added
API WRITE
alexgarel
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Name still contains Eco_score
|
stephanegigandet
changed the title
stephanegigandet
had a problem deploying
to
off-net
GitHub Actions
Failure
alexgarel
reviewed
Dec 18, 2024
alexgarel
approved these changes
Dec 18, 2024
stephanegigandet
added a commit
that referenced
this pull request
Dec 18, 2024
…w external name and logos (#11142) Continuation of #11117 We will soon rename the Eco-Score to a new name. To ease the transition to a new name and be more future proof, we will rename all Eco-Score internal fields to a generic "environmental score" field. Important notes: - the internal attribute id "ecoscore" is not renamed, as it is stored in clients. - for the time being, we keep the internal facet id "ecosore" and we copy environmental_score_tags to ecoscore_tags so that MongoDB and off-query can continue to work - in order for attributes and knowledge panels to work before Eco-Score has been recomputed (and new environmental_scores fields have been created), the attributes and knowledge panels will use ecoscore_data if environmental_data is not present. Plan discussed in https://docs.google.com/document/d/1LL8-aiSF482xaJ1o0AKmhXB5QWfVE0_jzvYakq3VXys/edit?tab=t.0#heading=h.pirt3xscsuwq
|
Deployed through #11142 closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will soon rename the Eco-Score to a new name.
To ease the transition to a new name and be more future proof, we will rename all Eco-Score internal fields to a generic "environmental score" field.
Important notes:
The name and images displayed to users will still be Eco-Score for now, but it will be changed to a new name at some point.
Plan discussed in https://docs.google.com/document/d/1LL8-aiSF482xaJ1o0AKmhXB5QWfVE0_jzvYakq3VXys/edit?tab=t.0#heading=h.pirt3xscsuwq