Code Cleanup

[beetleskin]

Fixes #76 and #75

Test Plan:

• find missing violations of http://wiki.ros.org/CppStyleGuide (might be easier with a clang-tidy config we could also use instead of my manual refactoring? maybe as a next step ..)
• confirm no regression in functionality
• confirm compilation on clean docker (we need a CI .. ;))

[schra]

I'll look at this once we have merged your other PRs :)

[schra]

Just as a reminder from #72, could you maybe add this small change in this PR too?

When clearing the topic input, the error will be "No map received yet" - maybe we should change that to "No NavSatFix message received yet"?

[beetleskin]

lets do that after review/concerns fixed - just remind me ;)

[beetleskin]

#77 is also part of this PR, I'll rebase after #77 is merged

[beetleskin]

@schra are we using a fork of https://github.com/davetcoleman/roscpp_code_format ? what about clang-format and camelCase vs. under_score? Can one set that in the config? Or is that only something clang-tidy can do? Should we add a clang-tidy config? Is there one for ROS? I only know the one from moveit (https://github.com/ros-planning/moveit/blob/master/.clang-tidy).
So many questions? :)

[schra]

Nice :)!

Please rebase again on #77 (I did a small change there)

You missed two variables ;)

src (cleanup) $ cgrep --var --regex  ".*[a-z][A-Z].*" $(find -name "*.cpp" -or -name "*.h")

/home/andre/rviz_satellite/src/tile_cache.h:163:21:        TileId const toFind{ area.center.tile_server, { xx, yy }, area.center.zoom };
/home/andre/rviz_satellite/src/aerialmap_display.cpp:489:19:      TileId const toFind{ center_tile_->tile_server, { xx, yy }, center_tile_->zoom };

[schra]

@schra are we using a fork of https://github.com/davetcoleman/roscpp_code_format

yes

what about clang-format and camelCase vs. under_score? Can one set that in the config? Or is that only something clang-tidy can do? Should we add a clang-tidy config? Is there one for ROS? I only know the one from moveit (https://github.com/ros-planning/moveit/blob/master/.clang-tidy).

That's a really good point. I'll add a remark about this in #78 And yeah, I think you can only do that with clang-tidy :)

[beetleskin]

You missed two variables ;)

inferior humans ..

I rebased, and fixed concerns - the new commit should be merged into the previous one; but I'd keep the others as they are

[beetleskin]

Its a shame that it's so hard to keep track of unused includes in C++ ..

[schra]

LGTM now, thanks again :)