Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI integration #78

Closed
beetleskin opened this issue Apr 19, 2020 · 3 comments
Closed

CI integration #78

beetleskin opened this issue Apr 19, 2020 · 3 comments

Comments

@beetleskin
Copy link
Contributor

.. or should we rather stick with the ROS buildfarm hooks?

However, we should incorporate basic CI checks, linting and unit-testing.

@schra schra changed the title Can we use Github actions for testing and linting? CI integration Apr 19, 2020
@schra
Copy link
Collaborator

schra commented Apr 19, 2020

Yeah this is something that we definitely should do. I also think integration into the ROS buildfarm is something we should do anyway.

It seems that there is no GitHub-integration of the ROS buildfarm? If you look at a ROS repo, for example https://github.com/ros-planning/moveit, they always use Travis.

I'm not familiar with both GitHub actions or Travis, but I'll have a look at this.

@schra schra mentioned this issue May 5, 2020
@schra
Copy link
Collaborator

schra commented May 5, 2020

Idea from #79:

what about clang-format and camelCase vs. under_score? Can one set that in the config? Or is that only something clang-tidy can do? Should we add a clang-tidy config? Is there one for ROS? I only know the one from moveit (https://github.com/ros-planning/moveit/blob/master/.clang-tidy).

Timple added a commit that referenced this issue Jan 19, 2021
@Timple
Copy link
Member

Timple commented Jan 19, 2021

Enabled ros_industrial CI with catkin_lint

@Timple Timple closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants