Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDK: install path fixes for meson and Ubuntu 24.04 #3598

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions lisa/operating_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -2094,6 +2094,35 @@ def _initialize_package_installation(self) -> None:
"There are no enabled repositories defined in this image.",
)

def _uninstall_packages(
self,
packages: List[str],
signed: bool = True,
timeout: int = 600,
extra_args: Optional[List[str]] = None,
) -> None:
add_args = self._process_extra_package_args(extra_args)
command = f"zypper --non-interactive {add_args}"
if not signed:
command += " --no-gpg-checks "
command += f" rm {' '.join(packages)}"
self.wait_running_process("zypper")
install_result = self._node.execute(
command, shell=True, sudo=True, timeout=timeout
)
if install_result.exit_code in (1, 100):
raise LisaException(
f"Failed to install {packages}. exit_code: {install_result.exit_code}, "
f"stderr: {install_result.stderr}"
)
elif install_result.exit_code == 0:
self._log.debug(f"{packages} is/are installed successfully.")
else:
self._log.debug(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the reboot be a specified exit code? Why are only 1/100 failed codes?

Copy link
Collaborator Author

@mcgov mcgov Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am following the convention of the install_packages code for SUSE. I'm assuming it was based on https://manpages.opensuse.org/Tumbleweed/zypper/zypper.8.en.html

The others seem to be info error codes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the doc, I feel only 0 means success. For example, 2 means command parameter errors, 3 means invalid args ...

f"{packages} is/are installed."
" A system reboot or package manager restart might be required."
)

def _install_packages(
self,
packages: List[str],
Expand Down
Loading