DPDK: install path fixes for meson and Ubuntu 24.04 #3598
+58
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 14, 2025
| elif install_result.exit_code == 0: | ||
| self._log.debug(f"{packages} is/are installed successfully.") | ||
| else: | ||
| self._log.debug( |
There was a problem hiding this comment.
Should the reboot be a specified exit code? Why are only 1/100 failed codes?
There was a problem hiding this comment.
I am following the convention of the install_packages code for SUSE. I'm assuming it was based on https://manpages.opensuse.org/Tumbleweed/zypper/zypper.8.en.html
The others seem to be info error codes
There was a problem hiding this comment.
I read the doc, I feel only 0 means success. For example, 2 means command parameter errors, 3 means invalid args ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some bugs which were noted after testing on Ubuntu 24.04: