-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45899: Write a Task to compute Ex for TEx #389
Conversation
611250a
to
66885c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's actually a guide on how to transfer code between packages: https://developer.lsst.io/stack/transferring-code.html#transferring-code-between-packages
Although the history is minimal, it'd be a good practice to follow this procedure.
994ec6c
to
19db5fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transfer branch should move the code as it was. Suggested doc changes and updating the default values to correspond to treecorr v4.3
should happen after the transfer branch is merged to the ticket branch.
8d3b8bc
to
3a05f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the default values in TreecorrConfig
suitable for the metric calculation? I don't quite remember what binning values we settled on, and what the default ones would be. ComputeExPsfConfig
should probably have a setDefaults
method that would set it to the nbins
, min_sep
, max_sep
and units
values appropriately.
92f4bcd
to
b665536
Compare
4885d75
to
63a32b2
Compare
dtype=TreecorrConfig, | ||
doc="treecorr config.", | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this needs an explicit validate
method that calls self.treecorr.validate
. Because TreecorrConfig
is not a ConfigClass
of a sub task, I am fairly certain that it will never be validated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There also needs to be a setDefaults
method here that sets the min_sep
, max_sep
and either nbins
or bin_size
as appropriate here corresponding to the requirements. @jmeyers314 - what was the binning we settled on finally for TEx computations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the validate
, I tried in the unit test and putting wrong value in ComputeExPsfConfig
(min_sep>max_sep
) for example and it triggered the validate
from TreecorrConfig
. Do I need to do more than that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be best to put it here, given that i) we might want to run this dynamically outside of computeSummaryStats
and ii) it makes sense for this class to have its own defaults for treecorr
rather than computeSummaryStats
setting them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in analysis_tools
PR - start the commit messages with upper case. Good to go after you set the defaults here in setDefaults
.
See https://rubinobs.atlassian.net/browse/DM-45899 for more informations.