-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error handling #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pkubanek
commented
Nov 16, 2023
- handleMissingReply method
- IRQTimeout handling
- removed doc from clean directories
- Ignore warning status (positive for NI).
- Don't clear buffer before writing loop - enables command chaining
- runLoop returns bool - true if that's last call in a loop
- Fixed IRQ responses
- Expanded DataTypes.h
- Fixed IRQ responses
- Expanded DataTypes.h
- Moved ACK_ to SAL/Command
- Fixed tests
pkubanek
force-pushed
the
tickets/DM-41336
branch
from
November 16, 2023 04:17
094735f
to
9a7907b
Compare
pkubanek
force-pushed
the
tickets/DM-41336
branch
from
November 16, 2023 04:21
9a7907b
to
ab01bcc
Compare
dmills-lsst
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.