forked from jsk-ros-pkg/jsk_robot
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update jsk_naoqi_robot/README.md #73
Merged
k-okada
merged 2 commits into
k-okada:pepper_cross
from
MiyabiTane:update_naoqi_readme_pepper_cross
Aug 14, 2022
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この部分は
https://github.com/k-okada/jsk_robot/pull/73/files#diff-375a422594be02bff5f6011ade16d89082a28a0fa467e818956252c15d831a5aR89-R99
で,
とすると,環境がセットされているとおもいます.なので,ここに書くとすると,例えば
として以下の出力になっているか確認すること,みたいな情報かな?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうすると、3.の
wstool merge -t src https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_naoqi_robot/naoqi.rosinstall
の部分も
wstool merge -t src https://github.com/k-okada/jsk_robot/blob/pepper_cross/jsk_naoqi_robot/naoqi.rosinstall
に書き換えたほうが良いのでしょうか??
https://github.com/k-okada/jsk_robot/pull/73/files#diff-375a422594be02bff5f6011ade16d89082a28a0fa467e818956252c15d831a5aL95
また、私の環境はmasterのREADMEでセットアップしたため、以下のようになっていて、少し異なっている気がして、4の項目ごとREADMEからなくすのが良いでしょうか...??
あまり理解できていなくてすみません
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
は,マージされたら,やっぱりもう一回書き換えることになるので,今のままでよいと思います。このPRがマージされたら,jsk-ros-pkg#1528 もマージしようと思います。
これはあったらよいので,一回
wstool merge -t src https://github.com/k-okada/jsk_robot/blob/pepper_cross/jsk_naoqi_robot/naoqi.rosinstall
で環境を作って,その時の情報にしましょう。として
とした結果をREADMEに書いておくので良いと思います。
と表示されるのは,しれっと,
に書き換えれば,今作っている環境は壊すことなく,作れると思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど、のちにmasterにマージされるのですね
このREADMEに従って環境をつくり、実機できちんと動くか確認しつつやってみようと思います、ありがとうございます