Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] add robot_pose_publisher in fetch_bringup.launch #1280

Merged
merged 9 commits into from
Jul 19, 2021

Conversation

knorth55
Copy link
Member

I add robot_pose_publisher in fetch_bringup.launch for rwt_nav

tork-a/visualization_rwt#96

cc. @708yamaguchi

Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
I think this is OK.

By the way, is rwt_nav currently running on Fetch15 or Fetch1075?
I cannot find the port number...

@knorth55 knorth55 added this to the 1.1.1 milestone Jan 7, 2021
@708yamaguchi
Copy link
Member

Thank you for your offline talk.
I can access rwt_nav!

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@708yamaguchi should we add

#robot_pose_publisher is not released in melodic
# https://github.com/GT-RAIL/robot_pose_publisher/issues/8
# robot_pose_publisher is needed for rwt_nav
- git:
    local-name: GT-RAIL/robot_pose_publisher
    uri: https://github.com/GT-RAIL/robot_pose_publisher.git
    version: 0.2.4

to https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.melodic ?

@708yamaguchi
Copy link
Member

In my understanding, we can access /robot_pose topic published in fetch's PC from web browser, so robot_pose_publisher is needed only in fetch's PC.

So I think robot_pose_publisher does not need to be added to jsk_fetch_user.rosinstall.melodic.

@knorth55
Please teach me if my understanding is wrong...

@knorth55
Copy link
Member Author

@708yamaguchi

So I think robot_pose_publisher does not need to be added to jsk_fetch_user.rosinstall.melodic.

Yes, you are right.

@k-okada
Copy link
Member

k-okada commented Jul 16, 2021

oh, I mean jsk_fetch.rosinstall

@708yamaguchi
Copy link
Member

708yamaguchi commented Jul 17, 2021

@k-okada
Copy link
Member

k-okada commented Jul 18, 2021

@708yamaguchi So can we close this PR?

@knorth55
Copy link
Member Author

knorth55 commented Jul 18, 2021

we want to run pose_publisher in fetch_bringup.launch

@k-okada k-okada merged commit 572193e into jsk-ros-pkg:master Jul 19, 2021
@knorth55 knorth55 deleted the fetch-robot-pose-publisher branch July 19, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants