The gas grid newly defined variables have been added. #8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,57 @@ | ||||||
| - Capacity|Natural Gas|Regasifier: | ||||||
| description: Regasifier upperbound capacity | ||||||
| unit: GW | ||||||
| - Capacity|Hydrogen|Regasifier: | ||||||
| description: Regasifier upperbound capacity | ||||||
| unit: GW | ||||||
| - Capacity|Natural Gas|Storage|Aquifer: | ||||||
| description: Aquifer storage capacity | ||||||
| unit: GWh | ||||||
| - Capacity|Natural Gas|Storage|Salt Cavern: | ||||||
| description: Salt Cavern storage capacity | ||||||
| unit: GWh | ||||||
| - Capacity|Natural Gas|Storage|Depleted Field: | ||||||
| description: Depleted Field storage capacity | ||||||
| unit: GWh | ||||||
| - Injection Rate|Natural Gas|Storage|Aquifer: | ||||||
| description: Aquifer storage Injection Rate | ||||||
| unit: GW | ||||||
| - Injection Rate|Gas|Storage|Salt Cavern: | ||||||
| description: Salt Cavern storage Injection Rate | ||||||
| unit: GW | ||||||
| - Injection Rate|Gas|Storage|Depleted Field: | ||||||
| description: Depleted Field storage Injection Rate | ||||||
| unit: GW | ||||||
| - Extraction Rate|Gas|Storage|Aquifer: | ||||||
| description: Aquifer storage Extraction Rate | ||||||
| unit: GW | ||||||
| - Extraction Rate|Gas|Storage|Salt Cavern: | ||||||
| description: Salt Cavern storage Extraction Rate | ||||||
| unit: GW | ||||||
| - Extraction Rate|Gas|Storage|Depleted Field: | ||||||
| description: Depleted Field storage Extraction Rate | ||||||
| unit: GW | ||||||
| - Network|Gas|Natural Gas|Capacity: | ||||||
|
There was a problem hiding this comment. Assuming that methane and hydrogen cannot use the same networks, I suggest to simplify to
|
||||||
| description: Capacity of the pipeline | ||||||
| unit: GW/h | ||||||
| - Network|Gas|Hydrogen|Capacity: | ||||||
| description: Capacity of the pipeline | ||||||
| unit: GW/h | ||||||
| - Network|Gas|Hydrogen|Length: | ||||||
| description: Length of the pipeline | ||||||
| unit: km | ||||||
| - Network|Gas|Natural Gas|Length: | ||||||
| description: Length of the pipeline | ||||||
| unit: km | ||||||
| - Network|Gas|Natural Gas|Offshore Length: | ||||||
|
There was a problem hiding this comment. This is obviously a subcategory of pipeline length.
Suggested change
|
||||||
| description: Length of the offshore part of the pipeline | ||||||
| unit: km | ||||||
| - Network|Gas|Hydrogen|Offshore Length: | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| description: Length of the offshore part of the pipeline | ||||||
| unit: km | ||||||
| - Network|Gas|Hydrogen|Reversible: | ||||||
| description: If the carrier can flow in both directions | ||||||
| unit: | ||||||
| - Network|Gas|Natural Gas|Reversible: | ||||||
| description: If the carrier can flow in both directions | ||||||
| unit: | ||||||
|
Comment on lines
+52
to
+57
There was a problem hiding this comment. These are boolean values that cannot be represented by the IIASA database infrastructure and the IAMC format. I suggest to remove these variables for now and have a discussion later how this information could be handled. |
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why you sometimes use "Injection Rate|Natural Gas|Storage|Aquifer" but "Injection Rate|Gas|Storage|Salt Cavern" - shouldn't this be consistently used with "Natural Gas"?