-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The gas grid newly defined variables have been added. #8
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mixes two types of variables - the technical parameters that are fairly straightforward, plus other variables which are problematic for a number of reasons, like shares, nominal consumption, statistical descriptions...
I suggest to remove all Share and Final Energy variables from this PR, review, merge, then start another PR to discuss these items.
@@ -0,0 +1,96 @@ | |||
- Capacity|Natural Gas|Regasifier: | |||
description: Regasifier upperbound capacity | |||
unit: [GW] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to use lists here for the units - please fix in this entire file.
unit: [GW] | |
unit: GW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel. Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions inline
- Injection Rate|Natural Gas|Storage|Aquifer: | ||
description: Aquifer storage Injection Rate | ||
unit: GW | ||
- Injection Rate|Gas|Storage|Salt Cavern: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why you sometimes use "Injection Rate|Natural Gas|Storage|Aquifer" but "Injection Rate|Gas|Storage|Salt Cavern" - shouldn't this be consistently used with "Natural Gas"?
- Extraction Rate|Gas|Storage|Depleted Field: | ||
description: Depleted Field storage Extraction Rate | ||
unit: GW | ||
- Network|Gas|Natural Gas|Capacity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that methane and hydrogen cannot use the same networks, I suggest to simplify to
- Network|Natural Gas|Capacity
- Network|Hydrogen|Capacity
- Network|Gas|Natural Gas|Length: | ||
description: Length of the pipeline | ||
unit: km | ||
- Network|Gas|Natural Gas|Offshore Length: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously a subcategory of pipeline length.
- Network|Gas|Natural Gas|Offshore Length: | |
- Network|Gas|Natural Gas|Length|Offshore: |
- Network|Gas|Natural Gas|Offshore Length: | ||
description: Length of the offshore part of the pipeline | ||
unit: km | ||
- Network|Gas|Hydrogen|Offshore Length: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Network|Gas|Hydrogen|Offshore Length: | |
- Network|Gas|Hydrogen|Length|Offshore: |
- Network|Gas|Hydrogen|Reversible: | ||
description: If the carrier can flow in both directions | ||
unit: | ||
- Network|Gas|Natural Gas|Reversible: | ||
description: If the carrier can flow in both directions | ||
unit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are boolean values that cannot be represented by the IIASA database infrastructure and the IAMC format. I suggest to remove these variables for now and have a discussion later how this information could be handled.
The newly defined gas grid variables.