Skip to content

Commit

Permalink
removing rroeser directory since its moved to scripts/rroeser
Browse files Browse the repository at this point in the history
Summary:
tsia

move prototypes to scripts/rroeser
updates prototype with changes to hold a queue per thread for workstealing

Reviewed By: praihan

Differential Revision: D65762651

fbshipit-source-id: d205883de89dd7d7bf62c8aade468688f7dc5880
  • Loading branch information
Robert Roeser authored and facebook-github-bot committed Jan 10, 2025
1 parent 8cb5949 commit 1de3ca7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions thrift/conformance/stresstest/client/StressTestClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ folly::coro::Task<void> ThriftStressTestClient::timedExecute(Fn&& fn) {
LOG(ERROR) << e.what();
connectionGood_ = false;
co_return;
} catch (std::exception& e) {
LOG(WARNING) << "Request failed: " << e.what();
} catch (...) {
// LOG(1) << "Request failed: " << e.what();
stats_.numFailure++;
co_return;
}
Expand Down
6 changes: 4 additions & 2 deletions thrift/conformance/stresstest/server/StressTestServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#include <thrift/conformance/stresstest/util/IoUringUtil.h>

#include <rroeser/scripts/src/executor/WorkStealingExecutor.h>
#include <scripts/rroeser/src/executor/WorkStealingExecutor.h>
#include <folly/executors/CPUThreadPoolExecutor.h>
#include <thrift/lib/cpp2/server/ParallelConcurrencyController.h>
#include <thrift/lib/cpp2/server/SEParallelConcurrencyController.h>
Expand Down Expand Up @@ -198,10 +198,12 @@ std::shared_ptr<ThriftServer> createStressTestServer(
auto t = sanitizeNumThreads(FLAGS_cpu_threads);
if (enableWorkStealing()) {
LOG(INFO) << "Work stealing executor enabled";
executor = std::make_shared<folly::WorkStealingExecutor>(t, 4 * t);
executor =
std::make_shared<folly::WorkStealingExecutor>(FLAGS_cpu_threads);
if (FLAGS_work_stealing_executor_only) {
LOG(INFO) << "Request pile and concurrency controller disabled";
} else {
LOG(INFO) << "Work Stealing with controller";
RoundRobinRequestPile::Options options;
requestPile =
std::make_unique<RoundRobinRequestPile>(std::move(options));
Expand Down

0 comments on commit 1de3ca7

Please sign in to comment.