Undeprecate Rocket

Summary: It's ready for big leagues. We are already using it in a couple of places - e.g.: https://www.internalfb.com/code/fbsource/[289d62afaa36]/fbcode/libfb/go/cgo/sr/sr_v3.go?lines=85 Reviewed By: podtserkovskiy Differential Revision: D67503628 fbshipit-source-id: 224ee23eb5cbbcfb286557be24839ac6e6da9aba
facebook · Jan 10, 2025 · 8cb5949 · 8cb5949
1 parent e4f68f0
commit 8cb5949
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/thrift/lib/go/thrift/client.go b/thrift/lib/go/thrift/client.go
@@ -61,7 +61,7 @@ func WithUpgradeToRocket() ClientOption {
 	}
 }
 
-// Deprecated: Use WithUpgradeToRocket. This is only used for testing purposes.
+// WithRocket sets the transport to Rocket.
 func WithRocket() ClientOption {
 	return func(opts *clientOptions) {
 		opts.transport = TransportIDRocket

diff --git a/thrift/lib/go/thrift/transport.go b/thrift/lib/go/thrift/transport.go
@@ -30,7 +30,7 @@ const (
 	TransportIDUnknown TransportID = 0
 	// TransportIDHeader is the header transport
 	TransportIDHeader TransportID = 1
-	// Deprecated: use TransportIDUpgradeToRocket, this is only used for testing purposes.
+	// TransportIDRocket is the Rocket transport
 	TransportIDRocket TransportID = 2
 	// TransportIDUpgradeToRocket is the transport that upgrades header to rocket
 	TransportIDUpgradeToRocket TransportID = 3