Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading comment reg. 1 MB Sql Limitation #2903

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove misleading comment reg. 1 MB Sql Limitation #2903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,6 @@ private static String buildKeyNameWhereClause(String[] names) {

private static void populateEntitySet(SQLiteDatabase db, String sqlStatement, String[] args,
Hashtable<String, AsyncEntity> entitySet) {
//TODO: This will _only_ query up to about a meg of data, which is an un-great limitation.
//Should probably split this up SQL LIMIT based looped
//For reference the current limitation is about 10k rows with 1 field each.
Cursor walker = db.rawQuery(sqlStatement, args);
while (walker.moveToNext()) {
String entityId = walker.getString(walker.getColumnIndex("entity_key"));
Expand Down