Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading comment reg. 1 MB Sql Limitation #2903

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove misleading comment reg. 1 MB Sql Limitation #2903

merged 1 commit into from
Dec 4, 2024

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Nov 29, 2024 •
edited
Loading

There is no 1 MB limitaion on data we can can query in sql queries, the only limitaion is that a single sql row can't be more than 1 mb

PR Checklist

  • If I think the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, "Release Note" label is set and a "Release Note" is specified in PR description.

Automated test coverage

NA

Safety story

No code changes

@shubham1g5
Remove misleading comment
e662e56 
There is no 1 MB limitaion on data we can can query in sql queries, the only limitaion is that a sql row can't be more than 1 mb
@shubham1g5 shubham1g5 changed the title Remove misleading comment Remove misleading comment reg. 1 MB Sql Limitation Nov 29, 2024
@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Nov 29, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 merged commit d60d242 into master Dec 4, 2024
4 of 6 checks passed
@shubham1g5 shubham1g5 deleted the entityCacheLimitation branch December 4, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avazirna avazirna avazirna approved these changes

@ctsims ctsims Awaiting requested review from ctsims

Assignees
No one assigned
Labels
skip-integration-tests Skip android tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @avazirna