feat: Add @cypress/puppeteer plugin #28370
Conversation
This reverts commit d8b5f35.
chrisbreiding
changed the base branch from
develop
to
crb/nohoist-devtools-protocol
…nto issue-28023-cy-puppeteer
npm/puppeteer/README.md
Outdated
| on, | ||
| onMessage: { | ||
| async switchToTabAndGetContent (browser) { | ||
| // ... |
There was a problem hiding this comment.
@chrisbreiding I would probably put an explicit comment here that says you need to now write Puppeteer code to execute what you want. I think someone might copy/paste this and assume it should do what it says. 🙂
There was a problem hiding this comment.
Good idea. Addressed in 1d8356a
There was a problem hiding this comment.
Was this addressed? I don't see an explicit comment?
There was a problem hiding this comment.
Ah good catch, I had put the comment here but it's a good idea to add it in this spot as well.
There was a problem hiding this comment.
Actually addressed this time here
npm/puppeteer/README.md
Outdated
| ## yarn | ||
|
|
||
| ```sh | ||
| yarn add @cypress/puppeteer |
There was a problem hiding this comment.
| yarn add @cypress/puppeteer | |
| yarn add @cypress/puppeteer --dev |
There was a problem hiding this comment.
Addressed here
npm/puppeteer/README.md
Outdated
| - `onMessage` _required_: An object with string keys and function values (see more details [below](#onmessage)) | ||
| - `puppeteer` _optional_: The `puppeteer` library imported from `puppeteer-core`, overriding the default version of `puppeteer-core` used by this plugin | ||
|
|
||
| #### onMessage |
There was a problem hiding this comment.
Do we want to explicitly call out that you can't run cypress commands in the message handlers?
There was a problem hiding this comment.
Yeah I like it. Addressed here
|
|
||
| ## Compatibility | ||
|
|
||
| `@cypress/puppeteer` requires Cypress version 13.6.0 or greater. |
There was a problem hiding this comment.
Do we want to add a peerDependency in the package.json for this requirement?
There was a problem hiding this comment.
Good idea. Addressed here
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation? Updates for puppeteer and multi-tab testing cypress-documentation#5565type definitions?