chore: Don't hoist devtools-protocol

[chrisbreiding]

Additional details

This is a prerequisite for #28370.puppeteer-core has a dependency on a version of devtools-protocol which is incompatible with the version we use in various packages in the repo. If they get hoisted, it uses the version installed by puppeteer-core and causes type mismatches and CI failures.

This needs to be separate from #28370 since otherwise the release analyzer thinks it's making changes to the binary that requires a changelog entry, but #28370 is only a feature release for the @cypress/puppeteer npm package.

PR Tasks

• [N/A] Have tests been added/updated?
• [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
• [N/A] Have API changes been updated in the type definitions?

[cypress]

5 flaky tests on run #52465 ↗︎

0

554

6

0

5

Details:

add more retries to flaky tests
Project: cypress	Commit: 56b3d09c9e
Status: Passed	Duration: 13:03 💡
Started: Nov 22, 2023 1:07 PM	Ended: Nov 22, 2023 1:20 PM

  runs.cy.ts • 2 flaky tests • app-e2e

View Output

Test		Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params		Test Replay Screenshots
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button		Test Replay Screenshots

  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config		Test Replay Screenshots

  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App - Debug Page > shows information about a failed spec		Test Replay Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

Review all test suite changes for PR #28372 ↗︎

[emilyrohrbough]

@chrisbreiding what does one need to know with updating this in the future? are we ahead or behind playwright? Any reason we couldn't match versions?

[chrisbreiding]

@emilyrohrbough I don't think there's much to be concerned about in the future. If devtools-protocol is added as a dependency of another package and it's causing type-check errors, then it would also need to nohoist it.

As far as matching versions, we could certainly do that. I tried that out, but it would require changing some of the devtools-protocol types we reference and I didn't want to open that can of worms for the time being.

[emilyrohrbough]

The concern would really just be forgetting why it is here and it being harder to unwind and remove with all the other dependencies in the repo.

[chrisbreiding]

Yeah, I understand that concern. If only package.json supported comments. At the very least, the git blame can lead someone in the future back to this PR to see the reasoning for it.

[cypress-bot]

Released in 13.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.1, please open a new issue.