feat: throw error on invalid service access

cordiverse · Nov 21, 2024 · 1221aae · 1221aae
1 parent 7d3a9fe
commit 1221aae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/packages/core/src/reflect.ts b/packages/core/src/reflect.ts
@@ -43,7 +43,7 @@ class ReflectService {
     const lines = error.stack!.split('\n')
     lines.splice(1, 1)
     error.stack = lines.join('\n')
-    ctx.emit(ctx, 'internal/warning', error)
+    throw error
   }
 
   static handler: ProxyHandler<Context> = {

diff --git a/packages/core/src/registry.ts b/packages/core/src/registry.ts
@@ -188,7 +188,7 @@ class Registry<C extends Context = Context> {
     return this.plugin({ inject, apply: callback, name: callback.name })
   }
 
-  plugin(plugin: Plugin<C>, config?: any) {
+  plugin(plugin: Plugin<C>, config?: any, outerError = new Error()) {
     // check if it's a valid plugin
     const key = this.resolve(plugin, true)
     this.ctx.scope.assertActive()
@@ -199,7 +199,6 @@ class Registry<C extends Context = Context> {
       this._internal.set(key!, runtime)
     }
 
-    const outerError = new Error()
     return new EffectScope(this.ctx, config, async (ctx, config) => {
       const innerError = new Error()
       try {

diff --git a/packages/core/tests/invoke.spec.ts b/packages/core/tests/invoke.spec.ts
@@ -16,10 +16,9 @@ describe('functional service', () => {
       }
 
       protected [Service.invoke](init?: Config) {
-        const caller = this.ctx
-        expect(caller).to.be.instanceof(Context)
+        expect(this.ctx).to.be.instanceof(Context)
         let result = { ...this.config }
-        let intercept = caller[Context.intercept]
+        let intercept = this.ctx[Context.intercept]
         while (intercept) {
           Object.assign(result, intercept.foo)
           intercept = Object.getPrototypeOf(intercept)