feat: only reload plugin when config changed

cordiverse · Nov 21, 2024 · 7d3a9fe · 7d3a9fe
1 parent ab9d527
commit 7d3a9fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/events.ts b/packages/core/src/events.ts
@@ -1,4 +1,4 @@
-import { Awaitable, defineProperty, Promisify } from 'cosmokit'
+import { Awaitable, deepEqual, defineProperty, Promisify } from 'cosmokit'
 import { Context } from './context'
 import { EffectScope, ScopeStatus } from './scope'
 import { getTraceable, symbols } from './utils'
@@ -124,6 +124,7 @@ class EventsService {
       for (const acceptor of scope.acceptors) {
         if (acceptor(scope, config)) return true
       }
+      return deepEqual(scope.config, config)
     }, { global: true }))
   }
 

diff --git a/packages/loader/src/loader.ts b/packages/loader/src/loader.ts
@@ -18,7 +18,6 @@ declare module '@cordisjs/core' {
     'exit'(signal: NodeJS.Signals): Promise<void>
     'loader/config-update'(): void
     'loader/entry-init'(entry: Entry): void
-    'loader/entry-scope'(entry: Entry, type: string): void
     'loader/entry-check'(entry: Entry): boolean | undefined
     'loader/partial-dispose'(entry: Entry, legacy: Partial<EntryOptions>, active: boolean): void
     'loader/before-patch'(this: EntryUpdateMeta, entry: Entry): void