Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing pre commit #2393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixing pre commit #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .hooks/pre-commit
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#/bin/sh
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this bin/sh?

Copy link
Author

@KelvinChung2000 KelvinChung2000 Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script does not work if I am calling it with sh, at least for my system

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What OS are you on?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using PopOs (which is basically Ubuntu) with fish shells.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so it doesn't work because you're not on a POSIX compliant shell. In general, we want to keep using sh because it's lighter-weight and maximally portable.

Can you check what other folks have done when using fish with git hooks?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #! will inform what shell the script should run in, i.e. sh/bash. So using fish should not be a problem.

If I understand correctly, running the hook is executing the script. When I am running sh .git/hooks/pre-commit, it gives me the following error:

.git/hooks/pre-commit: 3: function: not found
.git/hooks/pre-commit: 5: shift: can't shift that many

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some look-up. On Ubuntu, by default, it points your sh to dash, so there is a chance that you might be running dash, but you don't know about it.


function check {
prog=$1
Expand Down
2 changes: 1 addition & 1 deletion setup_hooks.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#/bin/sh
#!/bin/sh

for hook in .hooks/*; do
hook_name=$(basename "$hook")
Expand Down