fixing pre commit #2393
fixing pre commit #2393
Conversation
| @@ -1,4 +1,4 @@ | |||
| #/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Can you make this bin/sh?
There was a problem hiding this comment.
The script does not work if I am calling it with sh, at least for my system
There was a problem hiding this comment.
I am using PopOs (which is basically Ubuntu) with fish shells.
There was a problem hiding this comment.
Okay, so it doesn't work because you're not on a POSIX compliant shell. In general, we want to keep using sh because it's lighter-weight and maximally portable.
Can you check what other folks have done when using fish with git hooks?
There was a problem hiding this comment.
The #! will inform what shell the script should run in, i.e. sh/bash. So using fish should not be a problem.
If I understand correctly, running the hook is executing the script. When I am running sh .git/hooks/pre-commit, it gives me the following error:
.git/hooks/pre-commit: 3: function: not found
.git/hooks/pre-commit: 5: shift: can't shift that many
There was a problem hiding this comment.
I did some look-up. On Ubuntu, by default, it points your sh to dash, so there is a chance that you might be running dash, but you don't know about it.
The pre-commit install is not working as expected. Start with
#!to correctly inform the shell and run it with bash/sh. I discovered it is not working because I am using the fish shell.