add selectedMOIs to saved search

[jklugherz]

it works!

selectedmoi.mov

[hanars]

I can pair on this with you if you want, but at a high level I think changing the behavior for onChange the way you did is probably not the right direction to get it to populate properly. For the issue with initial form population you mention, I think you need to change the componentDidUpdate callback on the LocusListSelector thats called when the loading of the locus list completes, and/or change formatPanelAppItems to handle the MOI filtering . And for the actual onChange behavior itself I think you just want to move the MOI selector up a level so its not nested under panelapp anymore

[jklugherz]

@hanars I implemented the PaLocusListSelector using the shouldComponentUpdate and componentDidUpdate approach (and removed the new listener component) but I'm still seeing the values reset, after the page loads.

Screen.Recording.2025-01-07.at.4.49.05.PM.mov

I logged the value inside of the PaMoiSelector render() and the first time it's logged it is accurately set (as [XD]) but on subsequent renders it's replaced with undefined. Do you have any ideas as to what's happening here?

[hanars]

Try looking into the componentDidUpdate method of LocusdListSelector which is what triggers the on change event when loading a locus list succeeds and see what it is using to trigger the onChange in that helper - its possible that its not properly passing throught the MOIs there

[jklugherz]

@hanars I got this to work!! had to really understand what was happening during the lifecycle methods to see when and where the locus state was being updated.

[hanars]

yay so excited this is working! One intr suggestion on syntax but otherwise looks awesome!

[hanars]

this would be slightly neater as a single reduce with a helper method

Suggested change

	const filteredItems = items.filter((item) => {
	if (!selectedMOIs || selectedMOIs.length === 0) {
	return true
	}
	const initials = moiToMoiInitials(item.pagene?.modeOfInheritance, false)
	return selectedMOIs.some((moi) => initials.includes(moi))
	})
	return filteredItems.reduce((acc, item) => {
	const hasSelectedMoi = (item, selectedMOIs) => {
	if (!selectedMOIs || selectedMOIs.length === 0) {
	return true
	}
	const initials = moiToMoiInitials(item.pagene?.modeOfInheritance, false)
	return selectedMOIs.some((moi) => initials.includes(moi))
	}
	...
	return items.reduce((acc, item) => {
	if (!hasSelectedMoi(item, selectedMOIs) {
	return acc
	}
	...