Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-point): create tracing api #417

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Conversation

acatl
Copy link
Collaborator

@acatl acatl commented Sep 9, 2019

What:

closes #416

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

via this api we are now tracing implementation agnostic

closes ViacomInc#416
@acatl acatl added this to the v6 Instrumentation milestone Sep 9, 2019
@acatl acatl self-assigned this Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #417 into canary will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           canary   #417   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     27    +2     
  Lines         424    457   +33     
  Branches       65     70    +5     
=====================================
+ Hits          424    457   +33
Impacted Files Coverage Δ
packages/data-point/src/DataPoint.js 100% <100%> (ø) ⬆️
packages/data-point/src/ReducerEntity.js 100% <100%> (ø) ⬆️
packages/data-point/src/resolve.js 100% <100%> (ø) ⬆️
packages/data-point/src/tracing/Span.js 100% <100%> (ø)
packages/data-point/src/tracing/trace-span.js 100% <100%> (ø)
packages/data-point/src/tracing/Tracer.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc81612...4ea378a. Read the comment docs.

@acatl acatl merged commit 561aca5 into ViacomInc:canary Sep 10, 2019
@acatl acatl deleted the 414-tracing-api branch September 10, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants