Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-point): implement opentracing interface #418

Merged
merged 3 commits into from
Sep 10, 2019

Conversation

acatl
Copy link
Collaborator

@acatl acatl commented Sep 9, 2019

What:

closes #414

This Pr must be merged after #417

Why:

Opentrace was incorrectly implemented before this.

How:

Checklist:

@acatl acatl added this to the v6 Instrumentation milestone Sep 9, 2019
@acatl acatl self-assigned this Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #418 into canary will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           canary   #418   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     28    +1     
  Lines         457    469   +12     
  Branches       70     71    +1     
=====================================
+ Hits          457    469   +12
Impacted Files Coverage Δ
...ages/data-point-tracers/opentracing/opentracing.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561aca5...43020c6. Read the comment docs.

@acatl acatl merged commit e8065cd into ViacomInc:canary Sep 10, 2019
@acatl acatl deleted the 414-implement-opentracing branch September 10, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants