Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensplat: init at 1.1.2 #305300

Merged
merged 2 commits into from
Apr 29, 2024
Merged

opensplat: init at 1.1.2 #305300

merged 2 commits into from
Apr 29, 2024

Conversation

jcaesar
Copy link
Contributor

@jcaesar jcaesar commented Apr 19, 2024

Description of changes

This PR adds OpenSplat, "A free and open source implementation of 3D gaussian splatting written in C++, focused on being portable, lean and fast.": https://github.com/pierotofy/opensplat

Notes for this PR:

  • To check basic functionality:
    nix shell nixpkgs#python311Packages.opensfm github:NixOS/nixpkgs/pull/305300/head#opensplatWithCuda
    git clone https://github.com/mapillary/OpenSfM/ opensfm
    cd opensfm
    git checkout 5e854bb43f046ac9277dcfc7a891bab8587f070f
    cd data/berlin # this is example data for structure from motion, not gaussian splatting, so the result will be pretty bad, i.e. only viewable from a narrow angle
    opensfm_run_all .
    ls images/* | save -f image_list.txt
    opensplat .
    # open https://antimatter15.com/splat/?url=https://splat.uav4geo.com/banana.splat and drag and drop the resulting splat.ply file onto it (sorry, I don't know a better way). rotate around to find a good angle
    
  • There's also a rocm/hip backend (and there will be a metals backend in the next release, it seems), but I don't have hardware, experience, or examples (there isn't a single package in nixpkgs uses cmake+hip+torch) to work with for that.
  • I have contributed the patch upstream
  • This is my second PR, the first hasn't been accepted yet. If there's a general issue with style, please do tell

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Apr 19, 2024
@jcaesar
Copy link
Contributor Author

jcaesar commented Apr 21, 2024

Result of nixpkgs-review pr 305300 run on x86_64-linux 1

2 packages built:
  • opensplat
  • opensplatWithCuda

@jcaesar jcaesar marked this pull request as ready for review April 21, 2024 02:30
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
@jcaesar jcaesar force-pushed the opensplat branch 2 times, most recently from 993813e to 7e3d3e5 Compare April 21, 2024 03:37
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opensplat/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, but I don't think I can test it. Merging anyway

@Aleksanaa Aleksanaa merged commit 4d8d19f into NixOS:master Apr 29, 2024
25 checks passed
@jcaesar jcaesar deleted the opensplat branch April 30, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants