Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressure is not density and weasdi is not snodi + #739 and #742 #736

Merged
merged 22 commits into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5641aa4
pressure is not density
SamuelTrahanNOAA Dec 15, 2023
cc3277a
wrong variable sent for snodi
SamuelTrahanNOAA Dec 15, 2023
90f53d3
point to sam's branch
SamuelTrahanNOAA Dec 15, 2023
aef4d41
revisions to slowfall accumulation from @tanyasmirnova
SamuelTrahanNOAA Dec 18, 2023
c642910
point to sam's branch
SamuelTrahanNOAA Dec 18, 2023
37e7fac
explain lakedepth corruption safeguards
SamuelTrahanNOAA Dec 18, 2023
9467355
module_sf_ruclsm.f90: explain the snow_mosaic=0 line
SamuelTrahanNOAA Dec 18, 2023
3b92892
point ccpp/physics to personal fork
JiliDong-NOAA Dec 18, 2023
551c120
add flag to track new freezing lake ice grids
JiliDong-NOAA Dec 18, 2023
45f1437
update ccpp/physics
JiliDong-NOAA Dec 18, 2023
1370371
update ccpp/physics
JiliDong-NOAA Dec 19, 2023
d466b78
change name of lake_freeze to flag_lakefreeze
JiliDong-NOAA Dec 19, 2023
1e814d6
ccpp/physics updated
JiliDong-NOAA Dec 19, 2023
6013b48
sync with develop
JiliDong-NOAA Dec 19, 2023
beb1152
update ccpp/physics
JiliDong-NOAA Dec 19, 2023
996c78d
ccpp/physics: merge ccpp-physics#142 and ufs/dev
SamuelTrahanNOAA Dec 19, 2023
78d9f27
merge #739
SamuelTrahanNOAA Dec 19, 2023
24a7eff
Merge remote-tracking branch 'upstream/develop' into clm-unit-fix
SamuelTrahanNOAA Dec 19, 2023
4c0ad7e
merge ccpp-physics#148 into ccpp/physics
SamuelTrahanNOAA Dec 19, 2023
3b7edbd
merge #742
SamuelTrahanNOAA Dec 19, 2023
4a371d6
fix mistake in merge: extra rho0 argument
SamuelTrahanNOAA Dec 20, 2023
c99a886
point to ufs/dev for ccpp/physics
SamuelTrahanNOAA Dec 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
url = https://github.com/SamuelTrahanNOAA/ccpp-physics
branch = clm-unit-fix
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
3 changes: 3 additions & 0 deletions ccpp/data/CCPP_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ module CCPP_typedefs
logical, pointer :: flag_cice(:) => null() !<
logical, pointer :: flag_guess(:) => null() !<
logical, pointer :: flag_iter(:) => null() !<
logical, pointer :: flag_lakefreeze(:) => null() !<
real (kind=kind_phys), pointer :: ffmm_ice(:) => null() !<
real (kind=kind_phys), pointer :: ffmm_land(:) => null() !<
real (kind=kind_phys), pointer :: ffmm_water(:) => null() !<
Expand Down Expand Up @@ -607,6 +608,7 @@ subroutine gfs_interstitial_create (Interstitial, IM, Model)
allocate (Interstitial%flag_cice (IM))
allocate (Interstitial%flag_guess (IM))
allocate (Interstitial%flag_iter (IM))
allocate (Interstitial%flag_lakefreeze (IM))
allocate (Interstitial%ffmm_ice (IM))
allocate (Interstitial%ffmm_land (IM))
allocate (Interstitial%ffmm_water (IM))
Expand Down Expand Up @@ -1297,6 +1299,7 @@ subroutine gfs_interstitial_phys_reset (Interstitial, Model)
Interstitial%flag_cice = .false.
Interstitial%flag_guess = .false.
Interstitial%flag_iter = .true.
Interstitial%flag_lakefreeze = .false.
Interstitial%ffmm_ice = Model%huge
Interstitial%ffmm_land = Model%huge
Interstitial%ffmm_water = Model%huge
Expand Down
6 changes: 6 additions & 0 deletions ccpp/data/CCPP_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,12 @@
units = flag
dimensions = (horizontal_loop_extent)
type = logical
[flag_lakefreeze]
standard_name = flag_for_lake_water_freeze
long_name = flag for lake water freeze
units = flag
dimensions = (horizontal_loop_extent)
type = logical
[ffmm_water]
standard_name = Monin_Obukhov_similarity_function_for_momentum_over_water
long_name = Monin-Obukhov similarity function for momentum over water
Expand Down
4 changes: 2 additions & 2 deletions ccpp/driver/GFS_diagnostics.F90
Original file line number Diff line number Diff line change
Expand Up @@ -4005,12 +4005,12 @@ subroutine GFS_externaldiag_populate (ExtDiag, Model, Statein, Stateout, Sfcprop
idx = idx + 1
ExtDiag(idx)%axes = 2
ExtDiag(idx)%name = 'snodi'
ExtDiag(idx)%desc = 'water equivalent snow depth over ice'
ExtDiag(idx)%desc = 'snow depth over ice'
ExtDiag(idx)%unit = 'mm'
ExtDiag(idx)%mod_name = 'gfs_sfc'
allocate (ExtDiag(idx)%data(nblks))
do nb = 1,nblks
ExtDiag(idx)%data(nb)%var2 => sfcprop(nb)%weasdi(:)
ExtDiag(idx)%data(nb)%var2 => sfcprop(nb)%snodi(:)
enddo

idx = idx + 1
Expand Down