Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix EditAccountsModal and EditNetworkModal checkboxes reseting back to default on rerender #29755

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ export const EditAccountsModal: React.FC<EditAccountsModalProps> = ({

useEffect(() => {
setSelectedAccountAddresses(defaultSelectedAccountAddresses);
}, [defaultSelectedAccountAddresses]);
}, [
// TODO: Fix the source of this prop value to be the same array instance each render
JSON.stringify(defaultSelectedAccountAddresses),
]);

const selectAll = () => {
const allNetworksAccountAddresses = accounts.map(({ address }) => address);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ export const EditNetworksModal = ({

useEffect(() => {
setSelectedChainIds(defaultSelectedChainIds);
}, [defaultSelectedChainIds]);
}, [
// TODO: Fix the source of this prop value to be the same array instance each render
JSON.stringify(defaultSelectedChainIds),
]);

const selectAll = () => {
const allNetworksChainIds = allNetworks.map(({ chainId }) => chainId);
Expand Down
Loading