Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix EditAccountsModal and EditNetworkModal checkboxes reseting back to default on rerender #29755

Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 16, 2025

Description

Fixes a bug in the EditAccountsModal and EditNetworkModal that occasionally causes any changes to the default selected checkboxes to be reset on component rerender.

Open in GitHub Codespaces

Related issues

See: #27847 (comment)

Manual testing steps

  1. For a dapp with permissions
  2. In the wallet UI, edit the dapp permissions
  3. Open the edit network modal
  4. Change some checkboxes to be different from what was default selected
  5. Wait
  6. The checkboxes should not revert back to the default selected

Do the same for the edit accounts modal

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title Fix edit accounts modal and edit network modal checkbox reset on rere… fix: Fix EditAccountsModal and EditNetworkModal checkboxes reseting back to default on rerender Jan 16, 2025
@jiexi jiexi marked this pull request as ready for review January 16, 2025 16:56
@jiexi jiexi requested a review from a team as a code owner January 16, 2025 16:56
@metamaskbot
Copy link
Collaborator

Builds ready [87517f8]
Page Load Metrics (1668 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33020101530400192
domContentLoaded13531962164517082
load13712013166817383
domInteractive237643199
backgroundConnect76622189
firstReactRender1674362110
getState475212211
initialActions01000
loadScripts9661472121114268
setupStore64711115
uiStartup155424161912252121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 32 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit cdd603c Jan 16, 2025
80 of 81 checks passed
@Gudahtt Gudahtt deleted the jl/fix-edit-accounts-network-modal-default-selected-effect branch January 16, 2025 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-wallet-api-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants