Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#41]KnotxServer response configuration - wildcards #46

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

dragarthPl
Copy link
Contributor

KnotxServer response configuration - wildcards

Description

Adds possibility to use wildcards in allowed headers configuration (also see knotx-server-http#41), test for wildcards

Motivation and Context

#41

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     62.04%   62.04%           
  Complexity      281      281           
=========================================
  Files            65       65           
  Lines          1515     1515           
  Branches         37       37           
=========================================
  Hits            940      940           
  Misses          553      553           
  Partials         22       22
Impacted Files Coverage Δ Complexity Δ
...ndler/http/response/writer/ServerResponseTest.java 100% <ø> (ø) 9 <0> (ø) ⬇️
...r/handler/http/response/writer/ServerResponse.java 97.56% <100%> (ø) 16 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567d223...c469801. Read the comment docs.

@malaskowski malaskowski merged commit 929eef7 into Knotx:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants