Make filtering allowed headers case-insensitive

[dragarthPl]

Description

For a reason we can use:

AllowedHeadersFilter.WildcardCaseInsensitive.create(strings);

I done refactor usage of AllowedHeadersFilter

Motivation and Context

#7 and PR-8

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

---

I hereby agree to the terms of the Knot.x Contributor License Agreement.

[malaskowski]

May I suggest renaming the PR:

Make filtering allowed headers case-insensitive
?
And please update the changelog with this info (and squash commits as always please).

[malaskowski]

@dragarth-7
I'm reviewing https://github.com/Knotx/knotx-commons/pull/8/files and now I wonder if there could be more tests for headers with wildcards here:
https://github.com/Knotx/knotx-commons/blob/master/src/test/java/io/knotx/commons/http/request/AllowedHeadersFilterTest.java#L33
?
E.g. Host-* or Content-*

[dragarthPl]

May I suggest renaming the PR:

Make filtering allowed headers case-insensitive
?
And please update the changelog with this info (and squash commits as always please).

Done

@dragarth-7
I'm reviewing https://github.com/Knotx/knotx-commons/pull/8/files and now I wonder if there could be more tests for headers with wildcards here:
https://github.com/Knotx/knotx-commons/blob/master/src/test/java/io/knotx/commons/http/request/AllowedHeadersFilterTest.java#L33
?
E.g. Host-* or Content-*

I can extend test by more cases. Are you want to discuss about that somewhere ? How will we process it ? By new tickets/topic ?

[malaskowski]

Depends what we decide on: Knotx/knotx-fragments#100 (comment)

Good start could be creating an issue in the knotx-commons to create more unit tests, or you may directly create a PR with more cases (that's also fine). We can discuss there if any more cases should be covered.

[malaskowski]

Thank you @dragarth-7

[dragarthPl]

@Skejven You need also merge changes from: Knotx/knotx-commons#14 if you want this changes working.

But i also must remark that in PR-14 from knotx-common we have discussion about that how wildcards/regex mechanizm should work.

See also other related changes that I prepared as PR:
Knotx/knotx-server-http#46
Knotx/knotx-fragments#100
and mentioned above:
Knotx/knotx-commons#14

[malaskowski]

Right, thanks my fingers were too quick with merging :)
I will revert and try to re-open this.
I was trusting too much in CI and just discovered this effect: Knotx/knotx-aggregator#25

[malaskowski]

@dragarth-7 may I ask you to open a new Pull Request (I can't reopen unfortunately). Sorry for the trouble.