Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump generic-filehandle for fixing CORS errors from Chrome cache pollution #1796

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

cmdcolin
Copy link
Collaborator

This bumps generic-filehandle to 2.1.0 which includes a refetch if it receives a presumed CORS error ("Failed to fetch" error message....)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1796 (dd97ef5) into master (afdd9e4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   58.66%   58.67%           
=======================================
  Files         457      457           
  Lines       21193    21193           
  Branches     5016     5016           
=======================================
+ Hits        12432    12434    +2     
+ Misses       8451     8449    -2     
  Partials      310      310           
Impacted Files Coverage Δ
packages/core/util/index.ts 81.81% <0.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 93.61% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdd9e4...dd97ef5. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

was able to get that fix in via pairing with rob :)

xref old issue #1511

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 11, 2021
@cmdcolin cmdcolin merged commit 60a3f4b into master Mar 11, 2021
@rbuels rbuels deleted the bump_generic_filehandle branch March 11, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant