Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional comment field to Marker #1698

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

nickblt
Copy link
Contributor

@nickblt nickblt commented Feb 15, 2024

Link the Issue(s) this Pull Request is related to.

Fixes #744

Summarize your change.

This adds an optional comment field to the Marker object as requested in #744

Reference associated tests.

Added new tests that specifically test to make sure the comment is being added and serialized/deserialized successfully

Copy link

linux-foundation-easycla bot commented Feb 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d22935e) 79.84% compared to head (74dd686) 79.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files         197      197              
  Lines       21796    21814      +18     
  Branches     4358     4362       +4     
==========================================
+ Hits        17403    17416      +13     
- Misses       2232     2233       +1     
- Partials     2161     2165       +4     
Flag Coverage Δ
py-unittests 79.83% <59.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tests/test_marker.py 95.55% <100.00%> (+1.26%) ⬆️
src/opentimelineio/marker.h 87.50% <50.00%> (-12.50%) ⬇️
src/opentimelineio/marker.cpp 57.89% <25.00%> (-4.61%) ⬇️
...entimelineio-bindings/otio_serializableObjects.cpp 36.07% <16.66%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22935e...74dd686. Read the comment docs.

Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@reinecke reinecke merged commit 013fe04 into AcademySoftwareFoundation:main Feb 15, 2024
45 checks passed
@nickblt nickblt deleted the addCommentToMarker branch February 15, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker: Add comment to schema
4 participants