-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional comment field to Marker #1698
Add optional comment field to Marker #1698
Conversation
533e2a4
to
2827ecf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
- Coverage 79.84% 79.83% -0.01%
==========================================
Files 197 197
Lines 21796 21814 +18
Branches 4358 4362 +4
==========================================
+ Hits 17403 17416 +13
- Misses 2232 2233 +1
- Partials 2161 2165 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
Signed-off-by: Nicholas Bui LeTourneau <[email protected]>
2827ecf
to
74dd686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Link the Issue(s) this Pull Request is related to.
Fixes #744
Summarize your change.
This adds an optional comment field to the Marker object as requested in #744
Reference associated tests.
Added new tests that specifically test to make sure the comment is being added and serialized/deserialized successfully