Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAFWriter: add support for comments #22

Closed
timlehr opened this issue Jun 28, 2023 · 2 comments · Fixed by #23
Closed

AAFWriter: add support for comments #22

timlehr opened this issue Jun 28, 2023 · 2 comments · Fixed by #23
Labels
help wanted Extra attention is needed

Comments

@timlehr
Copy link
Collaborator

timlehr commented Jun 28, 2023

Feature Request

Description

Currently the AAF writer doesn't translate user comments generated by the AAF reader (or manually by the user).

The adapter should translate comments from the clip / media reference onto the MasterMob and comments from the timeline onto the CompositionMob.
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Jun 28, 2023
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
4c3e54b 
Signed-off-by: Tim Lehr <[email protected]>
@timlehr timlehr mentioned this issue Jun 28, 2023
Merged
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Jun 28, 2023
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
99b6b62 
Signed-off-by: Tim Lehr <[email protected]>
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Jun 28, 2023
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
fad0141 
Signed-off-by: Tim Lehr <[email protected]>
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Jun 28, 2023
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
d2934e2 
Signed-off-by: Tim Lehr <[email protected]>
@jminor
Copy link
Member

jminor commented Feb 15, 2024

Related: support for an optional comment field on Marker was recently added to OTIO: AcademySoftwareFoundation/OpenTimelineIO#1698

@jminor jminor added the help wanted Extra attention is needed label Feb 15, 2024
@timlehr
Copy link
Collaborator Author

timlehr commented Mar 5, 2024

@jminor currently the AAF Writer doesn't do markers yet, so adding support for them would be a prerequisite.

timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Mar 6, 2024
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
6b510b0 
Signed-off-by: Tim Lehr <[email protected]>
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Mar 6, 2024
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
b7a0231 
Signed-off-by: Tim Lehr <[email protected]>
timlehr added a commit to timlehr/otio-aaf-adapter that referenced this issue Mar 25, 2024
@timlehr
AAFWriter: added support for AAF user comments (OpenTimelineIO#22)
d9c5c87 
Signed-off-by: Tim Lehr <[email protected]>
apetrynet pushed a commit that referenced this issue Mar 25, 2024
@timlehr
AAFWriter: added support for AAF user comments (#22) (#23)
fd8f9b3 
Signed-off-by: Tim Lehr <[email protected]>
markreidvfx pushed a commit to markreidvfx/otio-aaf-adapter that referenced this issue Mar 28, 2024
@timlehr @markreidvfx
AAFWriter: added support for AAF user comments (OpenTimelineIO#22) (O…
18dc246 
…penTimelineIO#23)

Signed-off-by: Tim Lehr <[email protected]>
markreidvfx pushed a commit to markreidvfx/otio-aaf-adapter that referenced this issue Mar 31, 2024
@timlehr @markreidvfx
AAFWriter: added support for AAF user comments (OpenTimelineIO#22) (O…
1a87079 
…penTimelineIO#23)

Signed-off-by: Tim Lehr <[email protected]>
markreidvfx pushed a commit to markreidvfx/otio-aaf-adapter that referenced this issue Apr 1, 2024
@timlehr @markreidvfx
AAFWriter: added support for AAF user comments (OpenTimelineIO#22) (O…
1913785 
…penTimelineIO#23)

Signed-off-by: Tim Lehr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AAFWriter: added support for AAF user comments (#22) timlehr/otio-aaf-adapter
2 participants
@jminor @timlehr